Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question Answering] Cache support for Model Overview Metrics #2166

Merged
merged 24 commits into from
Jul 7, 2023

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Jul 4, 2023

This adds support for caching object detection metrics within a dashboard session, such that the metrics will be automatically displayed if they had been computed for the same set of inputs previously.

This is also reflected with adding new cohorts:

image

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #2166 (7b9891e) into main (4506b0d) will decrease coverage by 10.54%.
The diff coverage is 16.66%.

❗ Current head 7b9891e differs from pull request most recent head c34ca30. Consider uploading reports for the commit c34ca30 to get more accurate results

@@             Coverage Diff             @@
##             main    #2166       +/-   ##
===========================================
- Coverage   88.69%   78.16%   -10.54%     
===========================================
  Files         117       26       -91     
  Lines        6352     2134     -4218     
===========================================
- Hits         5634     1668     -3966     
+ Misses        718      466      -252     
Flag Coverage Δ
unittests 78.16% <16.66%> (-10.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._vision/rai_vision_insights/rai_vision_insights.py 72.38% <0.00%> (ø)
...ibleai_text/rai_text_insights/rai_text_insights.py 72.56% <20.00%> (ø)

... and 114 files with indirect coverage changes

1 similar comment
1 similar comment
@Advitya17 Advitya17 enabled auto-merge (squash) July 5, 2023 23:18
1 similar comment
@Advitya17 Advitya17 disabled auto-merge July 6, 2023 17:22
@Advitya17 Advitya17 enabled auto-merge (squash) July 7, 2023 14:08
@Advitya17 Advitya17 merged commit d882424 into main Jul 7, 2023
91 checks passed
@Advitya17 Advitya17 deleted the agemawat/qa_cache branch July 7, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants