Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Aggregate Method for Model Overview Metrics with Object Detection #2234

Closed
wants to merge 4 commits into from

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Aug 10, 2023

torchmetrics has an update where they removed the aggregate arg - https://torchmetrics.readthedocs.io/en/stable/detection/mean_average_precision.html

Removed that arg accordingly.

Description

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #2234 (b80856f) into main (b887bf2) will decrease coverage by 10.25%.
The diff coverage is n/a.

❗ Current head b80856f differs from pull request most recent head cfcb279. Consider uploading reports for the commit cfcb279 to get more accurate results

@@             Coverage Diff             @@
##             main    #2234       +/-   ##
===========================================
- Coverage   88.58%   78.33%   -10.25%     
===========================================
  Files         129       26      -103     
  Lines        7366     2174     -5192     
===========================================
- Hits         6525     1703     -4822     
+ Misses        841      471      -370     
Flag Coverage Δ
unittests 78.33% <ø> (-10.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
..._vision/rai_vision_insights/rai_vision_insights.py 72.79% <ø> (+0.40%) ⬆️

... and 105 files with indirect coverage changes

@Advitya17
Copy link
Collaborator Author

Closing in favor of Lightning-AI/torchmetrics#2018

@Advitya17 Advitya17 closed this Aug 24, 2023
@Advitya17 Advitya17 deleted the agemawat/remove_agg_widget branch August 28, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants