Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to engine dictionary #915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brokoli777
Copy link

Fixes #773

This adds a local function to see if custom_values dictionary only contains strings. It will throw an error if the dictionary is not valid.
I have also added a test case for testing the code change.

Please let me know if there are any changes to be made, as it is my first time contributing to this codebase.

@brokoli777
Copy link
Author

brokoli777 commented Nov 13, 2024

Unfortunately, I couldn't run the unit tests due to the following error, but I tested it separately.

image

I have installed the packages from requirements.txt #Resolved

@marina-p
Copy link
Contributor

Hi, thank you for adding this validation. The PR and test looks good. We've had CI checks broken for a few weeks, I just re-enabled them and everything including the new test is passing, so I'll go ahead and merge this: https://github.com/microsoft/restler-fuzzer/actions/runs/12292021287. For troubleshooting running tests locally, what was the exact command/directory/environment?


In reply to: 2473982009

Copy link
Contributor

@marina-p marina-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marina-p marina-p force-pushed the validate-dictionary branch from dc85c39 to e18d2b2 Compare December 12, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The engine should validate the dictionary values are all quoted
2 participants