Skip to content
golangci-lint

fix(heartbeat): add nil check in heartbeat's metricscardinality #5017

Sign in to view logs

fix(heartbeat): add nil check in heartbeat's metricscardinality

fix(heartbeat): add nil check in heartbeat's metricscardinality #5017

Triggered via pull request January 31, 2025 13:17
@alexcastilioalexcastilio
synchronize #1293
alexcastilio/fix-metrics-cardinality
Status Failure
Total duration 5m 48s
Artifacts –

golangci-lint.yaml

on: pull_request
Matrix: Lint
Fit to window
Zoom out
Zoom in

Annotations

36 errors
Lint (windows, amd64): pkg/telemetry/telemetry_test.go#L149
Error return value of `simpleCounter.Write` is not checked (errcheck)
Lint (windows, amd64): pkg/telemetry/telemetry_test.go#L158
Error return value of `histogram3buckets.Write` is not checked (errcheck)
Lint (windows, amd64): pkg/telemetry/telemetry_test.go#L167
Error return value of `histogram5buckets.Write` is not checked (errcheck)
Lint (windows, amd64): pkg/telemetry/telemetry_test.go#L176
Error return value of `summary.Write` is not checked (errcheck)
Lint (windows, amd64): pkg/telemetry/telemetry_test.go#L126
Metric: test_counter Error: counter metrics should have "_total" suffix (promlinter)
Lint (windows, amd64): pkg/telemetry/telemetry_test.go#L131
Metric: 3buckets_histogram Error: metric name should not include type 'histogram' (promlinter)
Lint (windows, amd64): pkg/telemetry/telemetry_test.go#L137
Metric: 5buckets_histogram Error: metric name should not include type 'histogram' (promlinter)
Lint (windows, amd64): pkg/telemetry/telemetry_test.go#L142
Metric: test_summary Error: metric name should not include type 'summary' (promlinter)
Lint (windows, amd64)
issues found
Lint (windows, arm64): pkg/telemetry/telemetry_test.go#L149
Error return value of `simpleCounter.Write` is not checked (errcheck)
Lint (windows, arm64): pkg/telemetry/telemetry_test.go#L158
Error return value of `histogram3buckets.Write` is not checked (errcheck)
Lint (windows, arm64): pkg/telemetry/telemetry_test.go#L167
Error return value of `histogram5buckets.Write` is not checked (errcheck)
Lint (windows, arm64): pkg/telemetry/telemetry_test.go#L176
Error return value of `summary.Write` is not checked (errcheck)
Lint (windows, arm64): pkg/telemetry/telemetry_test.go#L126
Metric: test_counter Error: counter metrics should have "_total" suffix (promlinter)
Lint (windows, arm64): pkg/telemetry/telemetry_test.go#L131
Metric: 3buckets_histogram Error: metric name should not include type 'histogram' (promlinter)
Lint (windows, arm64): pkg/telemetry/telemetry_test.go#L137
Metric: 5buckets_histogram Error: metric name should not include type 'histogram' (promlinter)
Lint (windows, arm64): pkg/telemetry/telemetry_test.go#L142
Metric: test_summary Error: metric name should not include type 'summary' (promlinter)
Lint (windows, arm64)
issues found
Lint (linux, arm64): pkg/telemetry/telemetry_test.go#L149
Error return value of `simpleCounter.Write` is not checked (errcheck)
Lint (linux, arm64): pkg/telemetry/telemetry_test.go#L158
Error return value of `histogram3buckets.Write` is not checked (errcheck)
Lint (linux, arm64): pkg/telemetry/telemetry_test.go#L167
Error return value of `histogram5buckets.Write` is not checked (errcheck)
Lint (linux, arm64): pkg/telemetry/telemetry_test.go#L176
Error return value of `summary.Write` is not checked (errcheck)
Lint (linux, arm64): pkg/telemetry/telemetry_test.go#L126
Metric: test_counter Error: counter metrics should have "_total" suffix (promlinter)
Lint (linux, arm64): pkg/telemetry/telemetry_test.go#L131
Metric: 3buckets_histogram Error: metric name should not include type 'histogram' (promlinter)
Lint (linux, arm64): pkg/telemetry/telemetry_test.go#L137
Metric: 5buckets_histogram Error: metric name should not include type 'histogram' (promlinter)
Lint (linux, arm64): pkg/telemetry/telemetry_test.go#L142
Metric: test_summary Error: metric name should not include type 'summary' (promlinter)
Lint (linux, arm64)
issues found
Lint (linux, amd64): pkg/telemetry/telemetry_test.go#L149
Error return value of `simpleCounter.Write` is not checked (errcheck)
Lint (linux, amd64): pkg/telemetry/telemetry_test.go#L158
Error return value of `histogram3buckets.Write` is not checked (errcheck)
Lint (linux, amd64): pkg/telemetry/telemetry_test.go#L167
Error return value of `histogram5buckets.Write` is not checked (errcheck)
Lint (linux, amd64): pkg/telemetry/telemetry_test.go#L176
Error return value of `summary.Write` is not checked (errcheck)
Lint (linux, amd64): pkg/telemetry/telemetry_test.go#L126
Metric: test_counter Error: counter metrics should have "_total" suffix (promlinter)
Lint (linux, amd64): pkg/telemetry/telemetry_test.go#L131
Metric: 3buckets_histogram Error: metric name should not include type 'histogram' (promlinter)
Lint (linux, amd64): pkg/telemetry/telemetry_test.go#L137
Metric: 5buckets_histogram Error: metric name should not include type 'histogram' (promlinter)
Lint (linux, amd64): pkg/telemetry/telemetry_test.go#L142
Metric: test_summary Error: metric name should not include type 'summary' (promlinter)
Lint (linux, amd64)
issues found