Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename regression to delta and benchmark to baseline for perf-tests #1335

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

ritwikranjan
Copy link
Contributor

Description

This pull request involves renaming variables and types related to performance testing to improve clarity and consistency. The changes primarily focus on replacing the term "regression" with "delta" and "benchmark" with "baseline" across various files and functions.

Key changes include:

Variable Renaming:

  • test/e2e/jobs/perf.go: Renamed benchmarkFile to baselineFile and regressionFile to deltaFile. Updated corresponding references in the RunPerfTest function. [1] [2]

Type and Function Renaming:

Functionality Updates:

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@ritwikranjan ritwikranjan requested a review from a team as a code owner February 11, 2025 14:51
@ritwikranjan ritwikranjan force-pushed the fix/rename-regression branch 2 times, most recently from 2201c0f to ea82f5d Compare February 12, 2025 10:34
Copy link
Member

@SRodi SRodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritwikranjan ritwikranjan added this pull request to the merge queue Feb 14, 2025
Merged via the queue into microsoft:main with commit 9671e6f Feb 14, 2025
28 checks passed
@ritwikranjan ritwikranjan deleted the fix/rename-regression branch February 14, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants