Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shell): run bash as a login shell to get hostname in prompt #1336

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

wedaly
Copy link
Member

@wedaly wedaly commented Feb 11, 2025

Description

Running bash -l causes bash to source /etc/profile, which includes the hostname in the shell prompt.
This is useful for keeping track of where retina-shell is running if you have multiple terminals open.

Related Issue

N/A

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

image

Additional Notes

N/A


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@wedaly wedaly requested a review from a team as a code owner February 11, 2025 16:45
@wedaly wedaly requested review from SRodi and kamilprz February 11, 2025 16:45
Running `bash -l` causes bash to source /etc/profile,
which includes the hostname in the shell prompt.
This is useful for keeping track of where retina-shell
is running if you have multiple terminals open.

Signed-off-by: Will Daly <[email protected]>
@wedaly wedaly force-pushed the retina-shell-bash-login-shell branch from f11b36c to 3858ef1 Compare February 11, 2025 16:50
@wedaly wedaly changed the title shell: run bash as a login shell to get hostname in prompt feat (shell): run bash as a login shell to get hostname in prompt Feb 11, 2025
@wedaly wedaly changed the title feat (shell): run bash as a login shell to get hostname in prompt feat(shell): run bash as a login shell to get hostname in prompt Feb 11, 2025
@nddq nddq added this pull request to the merge queue Feb 11, 2025
Merged via the queue into microsoft:main with commit 265ee8a Feb 11, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants