Fix build break caused by @types/bluebird #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested changes
Jul 1, 2017
| @@ -38,6 +38,7 @@ | |||
| "devDependencies": { | |||
| "@microsoft/node-library-build": "~3.0.1", | |||
| "@types/gulp": "3.8.32", | |||
| "@types/karma": "0.13.33" | |||
| "@types/karma": "0.13.33", | |||
| "@types/bluebird": "3.5.3" | |||
There was a problem hiding this comment.
Should this be a pinnedVersion in rush.json instead?
There was a problem hiding this comment.
No. That approach would break anybody who tries to use gulp-core-build-karma without re-solving this problem themselves.
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone recently published a new
@types/bluebirdthat relies on TypeScript 2.3 syntax, which breaks our projects. We don't use@types/bluebird(and in fact recommend against using it), however it's an indirect dependency of the@types/karmapackage. Since it's an unconstrained dependency, the only way to lock its version it to add an explicit dependency on@types/bluebird.I opened DefinitelyTyped issue #360 to discuss this policy on their end. In the meantime, this PR will unblock
rush generatefor web-build-tools.