-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Refactor PackageExtractor into a separate package #4064
Merged
octogonz
merged 31 commits into
microsoft:main
from
D4N14L:user/danade/RefactorDeployManager
Apr 27, 2023
Merged
[rush] Refactor PackageExtractor into a separate package #4064
octogonz
merged 31 commits into
microsoft:main
from
D4N14L:user/danade/RefactorDeployManager
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
reviewed
Apr 20, 2023
...on/changes/@rushstack/deploy-manager/user-danade-RefactorDeployManager_2023-04-19-20-01.json
Outdated
Show resolved
Hide resolved
…k target is outside of the source folder
dmichon-msft
approved these changes
Apr 26, 2023
octogonz
reviewed
Apr 26, 2023
octogonz
approved these changes
Apr 26, 2023
…er/danade/RefactorDeployManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the DeployManager class and all associated classes and utilities into the
@rushstack/package-extractor
package.Fixes #3774
Details
@rushstack/package-extractor
PackageExtractor
class makesAsync.forEachAsync
to increase parallelismAsyncQueue
class which can be used alongsideAsync.forEachAsync
to provide a modifiable, async-iterable queue that can be iterated in parallelImport.resolveModule*Async
APIs to allow for async module/package path resolutionFileSystem.copyFilesAsync
typings issue with the options parameterHow it was tested
Tested locally against the rushstack-samples repo, comparing output of the existing version with the updated version. Tested re-linking using the
create-links.js
script.Impacted documentation
@rushstack/package-extractor
may warrant additional documentation on the Rushstack websiterush deploy
remains unchanged, as does schema fordeploy(-*).json
files