Skip to content

Commit

Permalink
Revert "Revert "chore: bump dotnet sdk to 8 (#406)""
Browse files Browse the repository at this point in the history
This reverts commit a86fa86.
  • Loading branch information
sebasgomez238 committed Oct 10, 2023
1 parent 011cef5 commit 0608dd9
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 7 deletions.
24 changes: 20 additions & 4 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -811,10 +811,6 @@ dotnet_diagnostic.CA1852.severity = suggestion
# CA1854: Prefer 'TryGetValue' over 'ContainsKey' and 'Item' when accessing dictionary items
dotnet_diagnostic.CA1854.severity = suggestion

# https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1859
# CA1859: Use culture-aware string operations
dotnet_diagnostic.CA1859.severity = suggestion

# https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1860
# CA1860: Avoid using 'Enumerable.Any()' extension method.
dotnet_diagnostic.CA1860.severity = suggestion
Expand All @@ -823,6 +819,18 @@ dotnet_diagnostic.CA1860.severity = suggestion
# CA1861: Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly
dotnet_diagnostic.CA1861.severity = suggestion

# https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862
# CA1862: Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison
dotnet_diagnostic.CA1862.severity = suggestion

# https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1865
# CA1865: Use 'string.StartsWith(char)' instead of 'string.StartsWith(string)' when you have a string with a single char
dotnet_diagnostic.CA1865.severity = suggestion

# https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869
# CA1869: Avoid creating a new 'JsonSerializerOptions' instance for every serialization operation. Cache and reuse instances instead.
dotnet_diagnostic.CA1869.severity = suggestion

# https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2000
# CA2000: Dispose objects before losing scope
dotnet_diagnostic.CA2000.severity = suggestion
Expand Down Expand Up @@ -1035,6 +1043,14 @@ dotnet_diagnostic.IDE0220.severity = suggestion
# IDE0251: Member can be made 'readonly'
dotnet_diagnostic.IDE0251.severity = suggestion

# https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0290
# IDE0290: Use primary constructor
dotnet_diagnostic.IDE0290.severity = suggestion

# https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0300
# IDE0290: Collection initialization can be simplified
dotnet_diagnostic.IDE0300.severity = suggestion

# https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide1006
# IDE1006: Naming rule violation: These words must begin with upper case characters: ...
dotnet_diagnostic.IDE1006.severity = suggestion
Expand Down
1 change: 1 addition & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<AnalysisMode>AllEnabledByDefault</AnalysisMode>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>$(NoWarn);CA1014;CS8002</NoWarn>
<SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
</PropertyGroup>

<PropertyGroup Label="Package">
Expand Down
5 changes: 2 additions & 3 deletions global.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"sdk": {
"version": "7.0.400",
"rollForward": "latestMajor",
"allowPrerelease": false
"version": "8.0.100-rc.1.23463.5",
"rollForward": "latestMajor"
}
}

0 comments on commit 0608dd9

Please sign in to comment.