Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CA1715 identifiers should have correct prefix #367

Merged
merged 3 commits into from
Sep 7, 2023
Merged

chore: CA1715 identifiers should have correct prefix #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fa7bbf
chore: CA1715 identifiers should have correct prefix
JamieMagee Sep 6, 2023
9c8ec41
Merge branch 'main' into users/jamagee/CA1715
JamieMagee Sep 6, 2023
e4005b5
Merge branch 'main' into users/jamagee/CA1715
JamieMagee Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,10 +734,6 @@ dotnet_diagnostic.CA1707.severity = suggestion
# CA1711: Identifiers should not have incorrect suffix
dotnet_diagnostic.CA1711.severity = suggestion

# https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1715
# CA1715: Prefix generic type names with 'T'
dotnet_diagnostic.CA1715.severity = suggestion

# https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1716
# CA1716: Identifiers should not match keywords
dotnet_diagnostic.CA1716.severity = suggestion
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Sbom.Common/Extensions/DictionaryExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ public static class DictionaryExtensions
/// Adds the value to the dictionary only if the value is not null,
/// and the if dictionary already doesn't contain the given key.
/// </summary>
/// <typeparam name="Tkey"></typeparam>
/// <typeparam name="TKey"></typeparam>
/// <typeparam name="TValue"></typeparam>
/// <param name="dictionary"></param>
/// <param name="key"></param>
/// <param name="value"></param>
/// <exception cref="ArgumentNullException"></exception>
public static void AddIfKeyNotPresentAndValueNotNull<Tkey, TValue>(
this IDictionary<Tkey, TValue> dictionary,
Tkey key,
public static void AddIfKeyNotPresentAndValueNotNull<TKey, TValue>(
this IDictionary<TKey, TValue> dictionary,
TKey key,
TValue value)
{
if (dictionary is null)
Expand Down