-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Fix Onnx Connector Memory Problem with Onnx #9716
base: main
Are you sure you want to change the base?
Conversation
Onnx currently faces memory issues when dividing functionality among multiple methods
Python Unit Test Overview
|
@TaoChenOSU Anything I can do here ? I only see that there is a timeout, do you experience this issue in other pipelines aswell ? Or is it just me ? |
Hi @nmoeller, our integration test pipeline is experiencing some issues. We are working on fixing it. Will merge this PR once it's fixed. |
Onnx currently faces memory issues when dividing functionality among multiple methods
Motivation and Context
I was experiencing weird non reproducible memory issues with connector when using phi-3 vision, after tracing the memory it turned out there are some issues when Parameters & Generation are not in the same function. I am already in contact with the PG to adress the issue also in onnx.
There seems to be a memory problem with pybind, because the parameters show a non deterministc behavior, but they should determistic.
To fix the current problem i've decided to merge the Parameter Method and the Generation Method.
Description
Contribution Checklist