.Net: Replace stj-schema-mapper source code with M.E.AI schema generation #9807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
eiriktsarpalis
had a problem deploying
to
integration
GitHub Actions
Failure
eiriktsarpalis
commented
Nov 25, 2024
| @@ -22,16 +22,20 @@ namespace Microsoft.SemanticKernel; | |||
| internal static class KernelJsonSchemaBuilder | |||
There was a problem hiding this comment.
I didn't remove this class to minimize churn, but at this point it seems reasonable to bake in this factory into KernelJsonSchema (and perhaps make it public).
eiriktsarpalis
commented
Nov 25, 2024
| @@ -15,12 +14,12 @@ namespace SemanticKernel.Connectors.OpenAI.UnitTests.Core; | |||
| /// </summary> | |||
| public sealed class OpenAIJsonSchemaTransformerTests | |||
| { | |||
| private static readonly JsonSchemaMapperConfiguration s_jsonSchemaMapperConfiguration = new() | |||
| private static readonly AIJsonSchemaCreateOptions s_jsonSchemaCreateOptions = new() | |||
There was a problem hiding this comment.
These unit test are testing implementation detail that has now been removed. I'll fix the failing build but will otherwise leave these as-is since they're testing the same configuration as the one being passed to the core client.
eiriktsarpalis
had a problem deploying
to
integration
GitHub Actions
Error
eiriktsarpalis
had a problem deploying
to
integration
GitHub Actions
Failure
eiriktsarpalis
had a problem deploying
to
integration
GitHub Actions
Failure
eiriktsarpalis
temporarily deployed
to
integration
GitHub Actions
Inactive
eiriktsarpalis
commented
Nov 25, 2024
| @@ -95,8 +95,8 @@ public void ItCanConvertToFunctionDefinitionsWithParameterTypesAndReturnParamete | |||
| { "type": "object", | |||
| "required": ["param1", "param2"], | |||
| "properties": { | |||
| "param1": { "type": "string", "description": "String param 1" }, | |||
| "param2": { "type": "integer", "description": "Int param 2" } } } | |||
| "param1": { "description": "String param 1", "type": "string" }, | |||
There was a problem hiding this comment.
The changes in the assertion reflect the fact that the new component inserts the description keyword at the start of the schema object. This reflects convention from JSON schema even though they are equivalent -- property order isn't significant in JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the source copied implementation from https://github.com/eiriktsarpalis/stj-schema-mapper with the equivalent component now made available through Microsoft.Extensions.AI.Abstractions.
cc @RogerBarreto @stephentoub @SergeyMenshykh