-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: updated tests and integration runners #9828
Open
eavanvalkenburg
wants to merge
20
commits into
microsoft:main
Choose a base branch
from
eavanvalkenburg:int_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+867
−538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Nov 26, 2024
eavanvalkenburg
force-pushed
the
int_tests
branch
2 times, most recently
from
November 26, 2024 12:22
cebb801
to
72c561f
Compare
westey-m
approved these changes
Nov 26, 2024
markwallace-microsoft
approved these changes
Nov 26, 2024
markwallace-microsoft
approved these changes
Nov 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 26, 2024
westey-m
approved these changes
Nov 26, 2024
markwallace-microsoft
approved these changes
Nov 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Split the integration tests into seperate ones for Memory and Completions Added code to allow the samples to run as well Moved containers to service containers. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 26, 2024
TaoChenOSU
reviewed
Nov 26, 2024
TaoChenOSU
reviewed
Nov 26, 2024
TaoChenOSU
reviewed
Nov 26, 2024
TaoChenOSU
reviewed
Nov 26, 2024
TaoChenOSU
reviewed
Nov 26, 2024
TaoChenOSU
reviewed
Nov 26, 2024
eavanvalkenburg
force-pushed
the
int_tests
branch
from
November 27, 2024 11:07
92a7140
to
00df0b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Split the integration tests into seperate ones for Memory and Completions
Added code to allow the samples to run as well
Moved containers to service containers.
Description
Contribution Checklist