Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Replaced IMemoryStore with IVectorStore in examples #9833

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dmytrostruk
Copy link
Member

Motivation and Context

Replaced IMemoryStore usage with IVectorStore in Semantic Kernel examples.

Contribution Checklist

@dmytrostruk dmytrostruk self-assigned this Nov 27, 2024
@dmytrostruk dmytrostruk requested a review from a team as a code owner November 27, 2024 02:02
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code documentation labels Nov 27, 2024
{
var builder = Kernel.CreateBuilder();

// Add Azure OpenAI chat completion service
builder.AddAzureOpenAIChatCompletion(
TestConfiguration.AzureOpenAI.ChatDeploymentName,
TestConfiguration.AzureOpenAI.Endpoint,
TestConfiguration.AzureOpenAI.ApiKey);
new AzureCliCredential());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing the example to check if the apikey is set in the secrets and use it instead. So this can work for customers and internal testing at the same time.

Similar on how I did it here:

if (config["AzureOpenAI:ApiKey"] is not null)

Suggested change
new AzureCliCredential());
new AzureCliCredential());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants