-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Replaced IMemoryStore with IVectorStore in examples #9833
Open
dmytrostruk
wants to merge
5
commits into
microsoft:main
Choose a base branch
from
dmytrostruk:replace-memory-store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+162
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
Issue or Pull requests regarding .NET code
documentation
labels
Nov 27, 2024
dmytrostruk
temporarily deployed
to
integration
November 27, 2024 02:03
— with
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Nov 27, 2024
westey-m
approved these changes
Nov 27, 2024
RogerBarreto
approved these changes
Nov 27, 2024
{ | ||
var builder = Kernel.CreateBuilder(); | ||
|
||
// Add Azure OpenAI chat completion service | ||
builder.AddAzureOpenAIChatCompletion( | ||
TestConfiguration.AzureOpenAI.ChatDeploymentName, | ||
TestConfiguration.AzureOpenAI.Endpoint, | ||
TestConfiguration.AzureOpenAI.ApiKey); | ||
new AzureCliCredential()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest changing the example to check if the apikey is set in the secrets and use it instead. So this can work for customers and internal testing at the same time.
Similar on how I did it here:
if (config["AzureOpenAI:ApiKey"] is not null) |
Suggested change
new AzureCliCredential()); | |
new AzureCliCredential()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Replaced
IMemoryStore
usage withIVectorStore
in Semantic Kernel examples.Contribution Checklist