Skip to content

upstream snmalloc-rs as part of snmalloc #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SchrodingerZhu
Copy link
Collaborator

No description provided.

@jayakasadev
Copy link

is this still in progress?

@SchrodingerZhu
Copy link
Collaborator Author

SchrodingerZhu commented Mar 21, 2025

I am still okay with this and I can continue contributing to the rust part at upstream.

If this is the decided approach to go, I will archive the downstream and put a pointer to upstream in its README.

@SchrodingerZhu
Copy link
Collaborator Author

Pros and cons on top of my head:

Pros

  1. Easier to sync up.
  2. Unified CI to make sure everything works

Cons

  1. CXX project will need to pull in extra rust code.
  2. Loss of downstream history

Some other issues:

Maybe it is better to unify the versions in some future releases.

@jayakasadev
Copy link

Additional pro:
Bazel users can directly depend on the snmalloc-rs target (assuming the pr is merged). They won't have to add both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants