-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure caption controls "dim out" when window loses NC focus (WM_NCACTIVATE?) #12632
Comments
Generally, I've been duping these to #4862. However, I totally missed the one other checkbox in #1625 about the caption button colors, so I'm gonna re-purpose this issue to track that element. Thanks!
To do this, we'd need to:
See also #10401, which never got finished. |
I'm psyched to see that #4862 was implemented. Is this still being worked on? |
Not currently, but it seems fairly trivial these days. The plumbing in #4862 should make it trivial. proposed "schema": captionButtons: {
foreground: ThemeColor,
background: ThemeColor (default: #00000000),
unfocusedForeground: ThemeColor,
unfocusedBackground: ThemeColor (default: #00000000),
} I don't really think we need to have separate knobs for each of the buttons. |
I may take a stab at this one if that is ok. |
@jamespack Go for it! |
is this issue still being worked on? |
I actually never started. Missed Mikes go ahead. @techy4shri if you are interested go at it 👍🏻 If I can find some free time I may still take a look though its not high on my wish list. Terminal as is today pretty much checks all my boxes 💯 🥇 |
hmm it does, thanks @jamespack ! @zadjii-msft let me know if there's anything else I should know about :) |
Windows Terminal version
1.13.10395.0
Windows build number
10.0.19044
Other Software
No response
Steps to reproduce
Expected Behavior
Current tab would go grey
Caption buttons would go grey
Actual Behavior
Neither titlebar element go grey
The text was updated successfully, but these errors were encountered: