-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using different colors in the titlebar for focused/unfocused windows #4862
Comments
Thanks for the suggestion! I'm going to track this as a part of #3327, which is our megathread for adding even more customization to the Terminal. This request fits in nicely with a lot of the other work being done there. |
I think the active titlebar color was in effect when I am using WT without tab (setting: "globals":{"alwaysShowTabs":false, "showTabsInTitlebar": false} ), but it was with before than or equal to version 0.10 . |
This behavior hasn't changed in 0.11, you're just running into the settings file changes we made. #5458 for more info. |
Thank you @DHowett-MSFT, I moved "globals" setting to root, and I got the original effect. |
I'm a new comer to Windows Terminal and have found it to be a revelation, especially when you combine being able to use beautiful fonts like Cascadia or Nerd Fonts. However, my heart sinks when I see that drab battleship grey for the title bar colour. What gets me is that there must have been an active decision to make it grey as opposed to leave it to the system default of using accent colours defined in systems settings. Whilst issue #3327 is being considered for development, I would hope in the mean time we could see a simple stop-gap solution being applied where Terminal just uses the Accent colours as defined in system settings. |
^yeah. #3327 is very different |
I have been googling for many hours trying to find a solution for making it possible to identify an active / in-active Office 365 application. This is totally of-topic for this Terminal-issue (sorry), but since we have the attention of some fine Microsoft engineers working on good stuff (linux) PLEASE let me know where to post this wish in the hopes that I can wake up who ever fell asleep in the "UX for beginners" class |
And Terminal's title bar elements don't dim when the window is inactive. Should I create an issue for this (if there isn't one already)? |
That is tracked at the root of issue #1625. Thanks! 😄 |
this is actually just like #1963 |
There's a subtle difference between this and #1963 - that one just wants to be able to set a custom titlebar color. This one wants to be able to set custom titlebar color when focused, and a different color when unfocused. |
note to self: The old colors in #12635 might be good candidates for the inactive window colors. We may be able to do that following the sameish steps as in #12632 (comment), without adding the rest of the theming settings. |
Adds `tabRow.unfocusedBackground` to the theme properties. When provided, the window will use this ThemeColor as the color of the tab row when the window is inactive. When omitted, the window will fall back to the default tab row color, `{"key": "TabViewBackground"}` from our App.xaml. * [ ] tests added. * [x] Closes #4862 * [ ] Needs a whole pile of docs updates, which we'll do at the end here. This actually helped validate #12992 quite a bit. I found a bunch of bugs concerning null colors, null objects. Json parsing is hard 😛
🎉This issue was addressed in #13049, which has now been successfully released as Handy links: |
Description of the new feature/enhancement
Context
When working on large monitors it is possible to have up to 6 windows in tiled mode. It is useful to know which one will pick up the keyboard actions without mouse or alt-tab hunting. For that it would be useful to have a different title bar color for the active window to distinguish it from all the other windows.
Solution on Windows
One can pick a color for the active window (
HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\DWM\AccentColor
, say soft blue, can be done through settings)and a color for inactive windows (
HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\DWM\AccentColorInactive
, say light gray, in windows 10 can be done through regedit only)Applications that work with the two values above: Windows Explorer, Registry Editor, Total Commander, Mozilla Firefox (default theme), Google Chrome (default theme).
Terminal seems to not work with the two values.
That may be at odds with the application identity. (The discontinued Microsoft Edge 44 used the same gray as a strong identity element, Microsoft Office programs also boldly state color identity and ignore
AccentColorInactive
, VSCode states identity as boldly, however it displays the titlebar in a different color when inactive).Nevertheless, screens only get larger and the use-case described above is likely to become more common.
In terms of how to implement that for Terminal, which displays tabs on the title bar, Firefox has the solution of using the accent color on all inactive tabs and highlighting the active tab using a brighter color. Chrome does the same.
The text was updated successfully, but these errors were encountered: