Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #17237 #18490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

WhatsACloud
Copy link

Summary of the Pull Request

Terminates the original connection after running restart-connection.

References and Relevant Issues

issue 17237

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

reproduce the bug in issue 17237; it should no longer occur.

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

@WhatsACloud
Copy link
Author

Hi @zadjii-msft! I hope my constant pings aren't annoying; if they are just let me know. I managed to fix the issue #17237 in this pull request. I also added a function _replaceConnectionForRestart which handles killing the old connection.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant