-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
powerplatform_user support environment without dataverse #529
Open
mawasile
wants to merge
17
commits into
main
Choose a base branch
from
mawasile/488-powerplatform_user-support-environment-without-dataverse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
powerplatform_user support environment without dataverse #529
mawasile
wants to merge
17
commits into
main
from
mawasile/488-powerplatform_user-support-environment-without-dataverse
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and enhance role management
… API user management
…security roles in API user management
…se users and update test cases
…tform_user-support-environment-without-dataverse
…rm configuration; add user and environment resources for Dataverse integration
…ironment and user creation logic with security roles
… test cases for environment role assignments
…improve debug messages for clarity
… test to handle empty responses
…se user creation with environment role validation
…moval to handle internal server errors with logging
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 73.35% 73.18% -0.18%
==========================================
Files 105 105
Lines 14957 15250 +293
==========================================
+ Hits 10972 11161 +189
- Misses 3306 3382 +76
- Partials 679 707 +28 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…logging for role removal
…or environment user creation
mawasile
requested review from
mattdot,
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
November 19, 2024 15:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
powerplatform_user
resource, focusing on adding support for environments without Dataverse and updating the user management workflow. The most important changes include adding support for non-Dataverse environments, modifying test workflows, and updating documentation.Support for Non-Dataverse Environments:
.changes/unreleased/added-20241118-091212.yaml
)powerplatform_user
resource to handle non-Dataverse environments, specifying that only 'Environment Admin' and 'Environment Maker' roles are allowed in such cases. (docs/resources/user.md
) [1] [2]Workflow Updates:
TestAccUserResource_Validate_Create_Environment_User
test. (.github/workflows/run_tests.yml
)Documentation Enhancements:
powerplatform_user
documentation to include a note about role compatibility when transitioning from non-Dataverse to Dataverse environments. (docs/resources/user.md
)Example Configuration Adjustments:
examples/resources/powerplatform_user/resource.tf
,examples/resources/powerplatform_user/outputs.tf
) [1] [2]Internal Code Refactoring:
Find
function to thearray
helper to facilitate searching within arrays. (internal/helpers/array/array.go
)internal/services/authorization/api_user.go
) [1] [2] [3] [4] [5] [6] [7] [8][Copilot is generating a summary...]