Allow DynamicData source to be on base types #4482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
approved these changes
Jan 2, 2025
Comment on lines
+813
to
+814
| // TODO: Should we pass true for includeNonPublic? | ||
| testMethodInfo = PlatformServiceProvider.Instance.ReflectionOperations.GetRuntimeMethod(methodBase.DeclaringType!, methodBase.Name, parameters, includeNonPublic: false); |
There was a problem hiding this comment.
I'd say no except if after the refactoring we no longer support internal test methods (I hope we have a test for that).
Please remove the comment or fix the code.
There was a problem hiding this comment.
includeNonPublic: false preserves the existing behavior. But I'm suspecting that to be a bug when DiscoverInternals is used, which is why I left it as "TODO". Let's discuss/investigate more on Monday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4347