Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCCM: fix timestamp extraction #1878

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented Feb 13, 2024

We weren't properly extracting the timestamp from the filename, we were just using the default 0 and sys.maxsize.

Before

> python3 -c 'from torchgeo.datasets import NCCM; print(NCCM("tests/data/nccm"))'
NCCM Dataset
    type: GeoDataset
    bbox: BoundingBox(minx=115.483402043364, maxx=115.48627665227318, miny=53.528522711204424, maxy=53.531397320113605, mint=0.0, maxt=9.223372036854776e+18)
    size: 3

After

> python3 -c 'from torchgeo.datasets import NCCM; print(NCCM("tests/data/nccm"))'
NCCM Dataset
    type: GeoDataset
    bbox: BoundingBox(minx=115.483402043364, maxx=115.48627665227318, miny=53.528522711204424, maxy=53.531397320113605, mint=1483225200.0, maxt=1577833199.999999)
    size: 3

@shreyakannan1205 @yichiac

@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Feb 13, 2024
@calebrob6 calebrob6 merged commit 842aef7 into microsoft:main Feb 23, 2024
24 checks passed
@adamjstewart adamjstewart deleted the fixes/nccm branch February 24, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants