Add Sentinel2_CDL Datamodule #1889
Conversation
github-actions
bot
added
testing
yichiac
changed the title
yichiac
changed the title
|
Are there any changes required to merge this datamodule? |
|
Also need to add this to docs |
|
Needs same changes as NCCM. |
github-actions
bot
added
the
documentation
This reverts commit 859f24e.
|
@adamjstewart Thanks for the review! |
| **kwargs: Any, | ||
| ) -> None: | ||
| """Initialize a new Sentinel2CDLDataModule instance. | ||
|
|
There was a problem hiding this comment.
Can you give an example of how to instantiate this class? It is non-obvious from the current docstring.
There was a problem hiding this comment.
The datamodule can be initialized like this:
datamodule = Sentinel2CDLDataModule(
crs="epsg:3857",
batch_size=64,
patch_size=224,
cdl_paths="data/cdl/",
sentinel2_paths="data/sentinel2/",
)
There was a problem hiding this comment.
cool, can you add that to the docstring?
| Returns: | ||
| A matplotlib Figure with the image, ground truth, and predictions. | ||
| """ | ||
| return self.cdl.plot(*args, **kwargs) |
There was a problem hiding this comment.
Does this plot work when using this with a SemanticSegmentation trainer?
There was a problem hiding this comment.
Yes, it's also tested in CI. It simply overrides the default that calls self.dataset.plot
There was a problem hiding this comment.
There are still a few details we need to work out for our paper experiments w.r.t. augmentations, but we can do that in a mass PR once all data modules are merged.
I agree with @calebrob6 that the documentation could always be improved, but this is also true for our existing datamodules, none of which give examples for instantiation. The foo_ prefix stuff is already used in some of our existing datamodules like NAIPChesapeake with no explanation. Let's make a tutorial for these someday that gives example usage. For now, I'll force merge this so we aren't holding up all other datamodule PRs.
| ) | ||
|
|
||
| self.train_aug = AugmentationSequential( | ||
| K.Normalize(mean=self.mean, std=self.std), |
There was a problem hiding this comment.
Reminder that we still need to figure this out for all data modules in a future PR
adamjstewart
dismissed
calebrob6’s stale review
Requests are partially resolved, better tutorials can be a future goal
This PR adds the datamodule for CDL + Sentinel-2 images.