Datasets: support os.PathLike #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
adamjstewart
commented
Sep 3, 2024
|
|
||
| hits = self.index.intersection(tuple(query), objects=True) | ||
| filepaths = cast(list[Path], [hit.object for hit in hits]) | ||
| filepaths = cast(list[str], [hit.object for hit in hits]) |
There was a problem hiding this comment.
As of #2270, we can reasonably expect hit.object to be a str by default.
adamjstewart
commented
Sep 3, 2024
| @@ -42,7 +41,7 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| Path: TypeAlias = str | pathlib.Path | |||
| Path: TypeAlias = str | os.PathLike[str] | |||
There was a problem hiding this comment.
This is the actual change of interest
calebrob6
approved these changes
Sep 6, 2024
|
@adamjstewart To the best of my knowledge there wasn't any technical reason to choose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #2173, all TorchGeo datasets now support both
strandpathlib.Pathpaths. However,pathlib.Pathis actually a subclass ofos.PathLike, and PEP 519 says to use:to type hint all paths (we skipped
bytesbecause it was a nightmare). This PR expands our support to all ofos.PathLike(although I don't know any subclasses other thanpathlib.Path).@pioneerHitesh was there a reason we chose
pathlib.Pathinstead ofos.PathLike?