Port TS PR 60566 (@import * as namespace cannot be used with @implements) #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ports changes from TS PR 60566, updating error baseline files and modifying the internal flag check for type-only alias use sites.
- Update baseline error files for import tag conformance tests
- Adjust expected error counts in submodule baselines
- Modify IsValidTypeOnlyAliasUseSite to include NodeFlagsJSDoc in the flag check
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testdata/baselines/reference/submoduleAccepted/conformance/importTag23.errors.txt.diff | Removed outdated baseline error diff content |
| testdata/baselines/reference/submodule/conformance/importTag23.errors.txt | Updated expected error count for /b.js |
| internal/ast/utilities.go | Expanded flag check to include NodeFlagsJSDoc |
jakebailey
changed the title
| @@ -3033,7 +3033,7 @@ func IsJSDocSingleCommentNode(node *Node) bool { | |||
| } | |||
|
|
|||
| func IsValidTypeOnlyAliasUseSite(useSite *Node) bool { | |||
| return useSite.Flags&NodeFlagsAmbient != 0 || | |||
| return useSite.Flags&(NodeFlagsAmbient|NodeFlagsJSDoc) != 0 || | |||
There was a problem hiding this comment.
Kind of funny that you didn't do this in the other PR.
DanielRosenwasser
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports https://github.com/microsoft/TypeScript/pull/60566/files