Fix signature help crash on parenthesized call expressions #1418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a nil pointer dereference crash that occurred when requesting signature help on parenthesized call expressions with specific trigger parameters.
Problem
The language server would crash with a nil pointer dereference when:
someCall()
(someCall())
triggerCharacter: "("
andtriggerKind: 2
The crash occurred in
GetSignatureHelpItems
at line 103 when trying to accesscandidateInfo.candidateInfo
without first checking ifcandidateInfo
was nil.Root Cause
The
getCandidateOrTypeInfo
function can returnnil
when it doesn't match any of the three invocation types (callInvocation, typeArgsInvocation, contextualInvocation). However, the calling code assumedcandidateInfo
would never be nil and attempted to access its fields directly, causing a panic.Solution
Added a simple nil check for
candidateInfo
before accessing its fields:This defensive programming approach prevents the crash while maintaining existing behavior for valid cases. When
candidateInfo
is nil, the function now returns nil (no signature help) instead of crashing.Testing
signatureHelpParenthesizedCall
that reproduces the crash scenarioFixes #1415.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.