support @type on parameters
#1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this in Svelte, where it's used on arrows with no obvious place to put a `@param` tag.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the @type JSDoc tag on function parameters, allowing type annotations to be applied directly to parameters as an alternative to @param tags. This feature is particularly useful for arrow functions where @param tags may not have an obvious placement location.
- Extends the reparser to handle
@typetags on parameter declarations - Updates type inference to recognize and apply
@typeannotations to parameters - Improves type accuracy for React component parameters using
@typeannotations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/parser/reparser.go | Adds handling for @type tags on parameter declarations in the reparser |
| testdata/baselines/reference/submodule/conformance/jsDeclarationsReactComponents.* | Test baseline updates showing improved type inference for React component parameters |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsReactComponents.types.diff | Baseline diff reduction showing convergence with TypeScript behavior |
jakebailey
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this in Svelte, where it's used on arrows with no obvious place to put a
@paramtag.