[qt 6.8.0] Runtime crash because of ICU

[troopa81]

Describe the bug

When building QGIS, I got a crash when starting the application inside the icu dll.

If we build without ICU, we get no crash and the application runs fine.

An issue with ICU has been fixed in 6.8.1 but I understand it has been patched so we are supposed to be OK on this.

Actually Qt is not building and releasing their binaries with ICU, so should vcpkg do the same until they maybe change their mind ?

Environment

• OS: Windows
• Compiler: Microsoft Visual Studio 2022

To Reproduce
Steps to reproduce the behavior:

1. Build QGIS (sorry, I don't have a simple example program to test with)
2. Run it
3. See crash

Expected behavior
No crash

Failure logs

Crash screenshots in Visual Studio

Stacktrace bottom

Stacktrace top

Additional context

None

[JonLiu1993]

@troopa81, Thanks for your issue. I suggest that we wait for the upstream to solve this problem and release a new version of Qt. We can directly upgrade the version instead of patching. What do you think?

[troopa81]

Looking at more closely, it seems that the vcpkg included patch doesn't include this fix, avoiding infinite recursion, which looks like exactly as the issue I get.

So, 2 possible solution:

• patch 6.8.0
• wait for 6.8.1

I'll try to propose the patch for 6.8.0 if I manage to find the time

[troopa81]

6.8.1 is already approved, so I'll test with 6.8.1