Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Bump baseline #59569

Merged
merged 2 commits into from
Dec 25, 2024
Merged

[vcpkg] Bump baseline #59569

merged 2 commits into from
Dec 25, 2024

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Nov 23, 2024

Pull in some updates (among these: Qt 6.8)

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 23, 2024
Copy link

github-actions bot commented Nov 23, 2024

🧮 Vcpkg update report

Added packages:
🍓 eigen3: 3.4.0#4 (Features: )
🍓 h3: 4.1.0 (Features: )
🍓 json-schema-validator: 2.3.0#2 (Features: )
🍓 libaec: 1.1.3 (Features: )
🍓 pdal-dimbuilder: 2.8.1 (Features: )

Removed packages:
🍄 getopt: 0#3 (Features: )
🍄 szip: 2.1.1#12 (Features: )

Updated packages:
🍇 blas: 2023-04-14#1 -> 2023-04-14#2
🍇 curl: 8.10.1#1 -> 8.11.1
🍇 fontconfig: 2.15.0#1 -> 2.15.0#2
🍇 gstreamer: 1.24.7 -> 1.24.7#2 +plugins-bad
🍇 harfbuzz: 10.0.1 -> 10.1.0
🍇 hdf5: 1.14.4.3#2 -> 1.14.4.3#3
🍇 kubazip: 0.2.6 -> 0.3.3
🍇 libcap: 2.70 -> 2.71
🍇 libiconv: 1.17#4 -> 1.17#5
🍇 libjpeg-turbo: 3.0.4 -> 3.1.0
🍇 libpng: 1.6.43#3 -> 1.6.44
🍇 libxslt: 1.1.37#4 -> 1.1.42 +profiler, thread -default-features
🍇 nanoflann: 1.6.1 -> 1.6.2
🍇 openblas: 0.3.28 -> 0.3.28#1
🍇 openssl: 3.3.2#1 -> 3.4.0
🍇 py-charset-normalizer: 3.4.0 -> 3.4.1
🍇 py-hatchling: 1.25.0 -> 1.27.0
🍇 py-packaging: 24.1#1 -> 24.2
🍇 py-pyqt-builder: 1.16.4 -> 1.17.0
🍇 py-pyqt6-sip: 13.8.0 -> 13.9.1
🍇 py-sip: 6.8.6#1 -> 6.9.1
🍇 py-urllib3: 2.2.3 -> 2.3.0
🍇 qt5compat: 6.7.3 -> 6.8.1
🍇 qtconnectivity: 6.7.3 -> 6.8.1
🍇 qtlanguageserver: 6.7.3 -> 6.8.1
🍇 qtpositioning: 6.7.3 -> 6.8.1
🍇 qtsensors: 6.7.3 -> 6.8.1
🍇 qtserialport: 6.7.3 -> 6.8.1
🍇 qtshadertools: 6.7.3 -> 6.8.1
🍇 qtwebchannel: 6.7.3 -> 6.8.1
🍇 qtwebsockets: 6.7.3 -> 6.8.1
🍇 sqlite3: 3.46.1 -> 3.47.2
🍇 utf8-range: 4.25.1 -> 5.29.1
🍇 vcpkg-tool-meson: 1.6.0 -> 1.6.1
🍇 xerces-c: 3.2.5 -> 3.3.0

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 1ab5060)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 1ab5060)

@m-kuhn
Copy link
Member Author

m-kuhn commented Nov 23, 2024

CC @troopa81 I think you have been waiting for this

@troopa81
Copy link
Contributor

Yes! I was actually building it on my computer 😅 But is there PyQt 6.8.0? I see no release. Or is it built with a previous version of pyqt?

@m-kuhn
Copy link
Member Author

m-kuhn commented Nov 23, 2024

It tries to build with a previous version, let's see if this succeeds

@m-kuhn m-kuhn marked this pull request as draft November 23, 2024 16:31
@m-kuhn
Copy link
Member Author

m-kuhn commented Nov 24, 2024

@troopa81 builds are there (without pyqt, if required we could use dev versions)

@troopa81
Copy link
Contributor

@m-kuhn I failed to use generated binaries. I just click the qgis.exe, the splashcreen appear and nothing. Is there anything else to do?

@nicogodet
Copy link
Member

I confirm there is something wrong with this build

@m-kuhn
Copy link
Member Author

m-kuhn commented Nov 27, 2024

Unsure if it's related to Qt 6.8 or missing bindings and I'm currently lacking the time to look deeper

@troopa81
Copy link
Contributor

Unsure if it's related to Qt 6.8 or missing bindings and I'm currently lacking the time to look deeper

I tried also another qt5 on another PR and it fails. There is maybe more...

@nicogodet
Copy link
Member

Windows Qt6 build from master works on my side

@troopa81
Copy link
Contributor

I'm building it on debug to check what happens

@m-kuhn m-kuhn force-pushed the vcpkg-bump-baseline branch from a1e7db5 to 17fa3f6 Compare November 30, 2024 13:30
@nicogodet
Copy link
Member

Artifact still crashes
Looks related to Qt 6.8

@m-kuhn
Copy link
Member Author

m-kuhn commented Dec 3, 2024

thanks for testing, I enabled console output, hopefully there's something interesting

@troopa81
Copy link
Contributor

I figured out what's the issue here see microsoft/vcpkg#42661

I managed to build a working version of QGIS with Qt 6.8.0.

I have a patch but do we want to push that or wait for vcpkg/Qt to fix upstream?

@m-kuhn
Copy link
Member Author

m-kuhn commented Dec 12, 2024

Thanks @troopa81 !
I guess we are not in a hurry to merge this, it was mostly for experimenting. I'd rather work with upstream and bump after. Do you know if the upcoming 6.8.1 update is also affected?

@troopa81
Copy link
Contributor

I guess we are not in a hurry to merge this, it was mostly for experimenting. I'd rather work with upstream and bump after. Do you know if the upcoming 6.8.1 update is also affected?

No I'll try to test it.

@troopa81
Copy link
Contributor

@m-kuhn Actuall, I think this is fixed in 6.8.1 (see my comment ). So I'm gonna wait for 6.8.1 which is already approved

@nicogodet
Copy link
Member

Note: PyQt is now 6.8.0
https://pypi.org/project/PyQt6/

src/app/CMakeLists.txt Outdated Show resolved Hide resolved
@m-kuhn
Copy link
Member Author

m-kuhn commented Dec 12, 2024

Hmm... looks like we need to wait for this to be merged

@m-kuhn m-kuhn force-pushed the vcpkg-bump-baseline branch 2 times, most recently from eed7125 to 3c84bae Compare December 24, 2024 09:51
@m-kuhn m-kuhn force-pushed the vcpkg-bump-baseline branch from 4e03f2b to 1ab5060 Compare December 25, 2024 07:00
@m-kuhn m-kuhn marked this pull request as ready for review December 25, 2024 09:44
@m-kuhn m-kuhn merged commit af5edcb into master Dec 25, 2024
31 checks passed
@m-kuhn m-kuhn deleted the vcpkg-bump-baseline branch December 25, 2024 09:45
@nirvn
Copy link
Contributor

nirvn commented Dec 25, 2024

I can't get enough of these vcpkg reports :) nice cleanup, approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants