-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kdreports] new port #42625
base: master
Are you sure you want to change the base?
[kdreports] new port #42625
Conversation
I got the following error when testing usage locally.
|
That's weird, |
Still reporting the same error. |
The documented CMake usage for Qt6 is:
https://doc.qt.io/qt-6/cmake-get-started.html This is what is supported in vcpkg. |
This is what the package is already doing, see https://github.com/KDAB/KDReports/blob/master/CMakeLists.txt#L118 |
I just created a cmake project on VS, and then called usage to compile it, and the above problem was reported. |
Does |
The kdsoap test is normal and can be used. |
Found the bug, it should be fixed now, Edit: bug is already fixed in latest master |
You found the typo in the right file now. I still think that dependency lookup up in the project and in the exported config should follow the same pattern, i.e.
should be paired with
which maps to exactly the same config lookup and targets, instead of requesting a different set of packages. |
Usage test passed with x64-windows triplet. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.