Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpopt] Suppress implicit-function-declaration #42662

Conversation

WangWeiLin-MV
Copy link
Contributor

Fix #42659, error with poptconfig.c:108:9: error: implicit declaration of function ‘glob_pattern_p’ [-Wimplicit-function-declaration] on Ubuntu 24.

Repro with GCC 14, suppress it to fix.

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port installation tests pass with the following triplets:

  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 12, 2024
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review December 12, 2024 08:09
@dg0yt
Copy link
Contributor

dg0yt commented Dec 12, 2024

Did you check if the declaration could be pulled in with a missing #include <...>?

The warning seems to be treated as an error. Should the port disable -Werror instead of disabling a particular warning?

@WangWeiLin-MV
Copy link
Contributor Author

Port run pass with test:

#include "popt.h"
#include <iostream>

int main(void) {
    std::cout << "libpopt" << std::endl;
    std::cout << POPT_OPTION_DEPTH << std::endl;
    poptContext context = poptGetContext(NULL, 0, 0, NULL, 0);
    poptFreeContext(context);
    return 0;
}

The warning seems to be treated as an error. Should the port disable -Werror instead of disabling a particular warning?

Build pass after adding the options.

@jiaolulu666
Copy link

libpopt now have no 1.16#18, qickly update that

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 13, 2024
@JavierMatosD JavierMatosD merged commit 3a7e5f1 into microsoft:master Dec 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libpopt] build failure
6 participants