[Libtomcrypt, libtommath] Add new port #8787
Conversation
|
|
|
/azp run |
|
/azp run |
LilyWangL
changed the title
ports/libtomcrypt/portfile.cmake
Outdated
| @@ -0,0 +1,55 @@ | |||
| include(vcpkg_common_functions) | |||
There was a problem hiding this comment.
include(vcpkg_common_functions) is deprecated. Please remove it.
ports/libtommath/portfile.cmake
Outdated
| @@ -0,0 +1,52 @@ | |||
| include(vcpkg_common_functions) | |||
There was a problem hiding this comment.
include(vcpkg_common_functions) is deprecated. Please remove it.
| @@ -0,0 +1,4 @@ | |||
| Source: libtomcrypt | |||
| Version: 1.18.2 | |||
There was a problem hiding this comment.
Can you please add the Homepage for this port in the CONTROL file?
Homepage: https://github.com/libtom/libtomcrypt
| @@ -0,0 +1,3 @@ | |||
| Source: libtommath | |||
| Version: 1.2.0 | |||
There was a problem hiding this comment.
Can you please add the Homepage for this port in the CONTROL file?
Homepage: https://github.com/libtom/libtommath
|
If this port doesn't support some triplets, please so these steps as below:
|
|
I would love to just add support for triplets, but I have no idea how to do it - is there any chance that triplet support could be added to the https://github.com/microsoft/vcpkg/blob/master/docs/examples/packaging-github-repos.md guide? The only thing I can find guidance for is how to add a new triplet, not how to use existing. |
|
/azp run |
|
Our CI testing system will test if the port can build successfully on the following triplets, you can click Details to check the build error log. Now the port build failed on some triplets as below. If this result is expected, please do the above steps: |
|
/azp run |
| INSTALL | ||
| ${SOURCE_PATH}/LICENSE | ||
| DESTINATION ${CURRENT_PACKAGES_DIR}/share/libtomcrypt/ RENAME copyright | ||
| ) |
There was a problem hiding this comment.
Could you please update
file(
INSTALL
${SOURCE_PATH}/LICENSE
DESTINATION ${CURRENT_PACKAGES_DIR}/share/libtomcrypt/ RENAME copyright
)
as
file(
INSTALL
${SOURCE_PATH}/LICENSE
DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright
)
?
| file(INSTALL | ||
| ${SOURCE_PATH}/LICENSE | ||
| DESTINATION ${CURRENT_PACKAGES_DIR}/share/libtommath/copyright | ||
| ) |
There was a problem hiding this comment.
Could you please update
file(INSTALL
${SOURCE_PATH}/LICENSE
DESTINATION ${CURRENT_PACKAGES_DIR}/share/libtommath/copyright
)
as
file(INSTALL
${SOURCE_PATH}/LICENSE
DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright
)
?
|
Hi @FredeJ |
|
Pinging @FredeJ for response. Is work still being done for this PR? |
|
Closing this PR since it seems that no progress is being made. Please reopen if work is still being done. |
I added libtommath and libtomcrypt.
I tried updating the solution file to be a newer version so it could be build with the
vcpkg_build_msbuildcommand. However I was advised to use the existingmakefile.msvcinstead usingnmake( see libtom/libtomcrypt#517 ).I made it build by inelegantly including
${CURRENT_PACKAGES_DIR}/..- what is the solution for elegantly including the currently built libraries?I ran into some issues with the approach, namely building a debug version (still not sure I'm doing that right) and building for x64 (unsolved as of yet). Additionally, I'm not completely sure how to go about building for linux and filtering correctly on the triplets.
Instead of just giving up and concluding that it's too much work to get non-cmake/msbuild packages to work with vcpkg I figured it would upload what I have now to get some feedback on how to proceed.