Refactor func CLI installation pretest logic #4731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
changed the title
MicroFish91
commented
Oct 6, 2025
|
|
||
| function installFuncCli() { | ||
| const funcDir = path.join(os.homedir(), 'tools', 'func'); | ||
| async function cleanReadme() { |
There was a problem hiding this comment.
I literally made zero changes to cleanReadme. I think it started seeing this as a change when I reordered the functions
alexweininger
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses two issues:
gulp preTeststarted breaking a while back, you can see this when running a long running testhttps://dev.azure.com/devdiv/DevDiv/_build/results?buildId=12514565&view=logs&j=36b3f9c6-e29e-5b82-0001-f267ab2d3d26&t=6adf503e-47f3-5605-25a5-142045d92ea9
requestpackage, which I believe has been deprecated for a while now. This removes that dependency and lets us just rely on the internal node https module instead.I also leverage the extract package, but we already have that as a dependency, so didn't have to install anything new.
Passing on mac, windows, and long running test pipeline