Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArcEnabledServers resource to AzExtResourceType enum #742

Merged

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Aug 24, 2023

We'll map it to an upcoming extension later, when it's ready.

@andyleejordan andyleejordan requested a review from a team as a code owner August 24, 2023 00:47
@andyleejordan
Copy link
Member Author

The documentation on Azure Arc if we want to figure out a better name. Also /cc @maertendMSFT

@andyleejordan andyleejordan changed the title Add Machines resource to AzExtResourceType enum Add ArcEnabledServers resource to AzExtResourceType enum Aug 29, 2023
@andyleejordan
Copy link
Member Author

Ok so "Azure Arc-enabled Servers" is the official name. Since "Azure" is implied by the type and this is just implementation, we're dropping that. We'll name the upcoming extension vscode-azurearcenabledservers. Not worried about localization or the legacyTypeMap.

alexweininger
alexweininger previously approved these changes Aug 29, 2023
We'll map it to an upcoming extension later, when it's ready.
@alexweininger alexweininger merged commit aea55ce into microsoft:main Aug 29, 2023
3 checks passed
@microsoft microsoft locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants