Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): Add Windows requirements #1429

Merged
merged 3 commits into from
Oct 13, 2023
Merged

docs(contributing): Add Windows requirements #1429

merged 3 commits into from
Oct 13, 2023

Conversation

JoseLion
Copy link
Contributor

Resolves #1428

@jdneo
Copy link
Member

jdneo commented Oct 12, 2023

I'll make sure it's reviewed before the end of the week

jdneo
jdneo approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The steps work on Windows 11 22H2

@jdneo jdneo merged commit 4083079 into microsoft:develop Oct 13, 2023
1 check passed
@jdneo jdneo added this to the 3.13.1 milestone Oct 13, 2023
@jdneo
Copy link
Member

jdneo commented Oct 13, 2023

Thank you @JoseLion for your contribution!

@JoseLion JoseLion deleted the docs/windows-requirements branch October 13, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

@testforstephen testforstephen Awaiting requested review from testforstephen testforstephen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.

[dev] Extension dependency grpc-tools v1.12.x does not work on Windows
2 participants
@JoseLion @jdneo