Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to TaskServerClient & Remove gradle daemon status discarded code #1531

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Rename to TaskServerClient & Remove gradle daemon status discarded code #1531

merged 1 commit into from
Jul 29, 2024

Conversation

Jiaaming
Copy link
Contributor

  1. I rename GradleClient to TaskServerClient for it's only the client for task server.
  2. I remove Gradle Daemon Status discarded code. They should be remove after this change: build: Move Gradle Daemons implementation from Java into Typescript #1489

@jdneo jdneo added this to the 3.16.0 milestone Jul 29, 2024
@jdneo jdneo added the eng engineering work label Jul 29, 2024
jdneo
jdneo approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo jdneo merged commit 34e0896 into microsoft:develop Jul 29, 2024
8 checks passed
@Jiaaming Jiaaming deleted the remove-gd-extra-code branch July 29, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

@testforstephen testforstephen Awaiting requested review from testforstephen testforstephen is a code owner

Assignees
No one assigned
Labels
eng engineering work
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiaaming @jdneo