Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only set notebook open context key if it uses a jupyter kernel #16226

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Nov 16, 2024

part of microsoft/vscode#233917

make the variable view more recognizable as not built-in and only show the view if a jupyter kernel is being used in an open notebook - we can't provide variables otherwise

@amunger amunger force-pushed the aamunger/showVariableViewLess branch from d9957a8 to 981e4f0 Compare November 16, 2024 00:30
@amunger amunger marked this pull request as ready for review November 18, 2024 18:45
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 18, 2024
@amunger amunger enabled auto-merge (squash) November 18, 2024 18:48
@amunger amunger merged commit 270fd6f into main Nov 18, 2024
25 checks passed
@amunger amunger deleted the aamunger/showVariableViewLess branch November 18, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants