Connection sharing #19542
Open
Connection sharing #19542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng SQL Server connections
…management - Added commands for connection sharing: getConnectionIdForActiveEditor, connect, disconnect, isConnected, executeSimpleQuery, getServerInfo, and editConnectionSharingPermissions. - Updated connection sharing approval logic to handle denied status. - Introduced method to retrieve connection info from a given file URI in ConnectionManager. - Modified type definitions for connect and getServerInfo methods to return promises and appropriate types.
- Created a new VS Code extension for connection sharing. - Added package.json to define extension metadata and commands. - Implemented the main extension logic in src/extension.ts, including a command to execute a simple query. - Added TypeScript configuration in tsconfig.json for strict type-checking. - Included a test suite in src/test/extension.test.ts with a sample test case. - Updated connectionSharingService.ts to handle new permission options including "Clear" for resetting approvals. - Enhanced user prompts for connection sharing permissions with current status indicators.
…and enhance connection sharing service
…ods and localized strings
…eporting instructions
aasimkhan30
requested review from
kburtram,
caohai,
laurenastrid1,
lewis-sanchez and
Benjin
as code owners
This was referenced Jun 10, 2025
PR Changes
|
|
Good day @aasimkhan30 ! In continue of #19456 Could we add a function to API - something like scriptObject, pass object name (table name, stored procedure, function etc.) and ScriptOperation (select, create, insert, update, delete, execute, alter) and get result script in string back? Thanks! |
…thod and update tests
caohai
approved these changes
Jun 23, 2025
Benjin
approved these changes
Jun 23, 2025
|
|
||
| 2. Open this sample extension in VS Code | ||
| 3. In the Run and Debug view, select the "Run Extension" configuration | ||
| 4. It should launch a new VS Code window with the extension activated |
There was a problem hiding this comment.
Aren't these the normal instructions for running the MSSQL extension? Does anything need to be changed here for connection-sharing-sample?
| @@ -0,0 +1,48 @@ | |||
| # Welcome to your VS Code Extension | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
PR Description
Fixes #19456
This PR adds support for managing third-party extension access to MSSQL connections through a permission-based model.
🔐 Permission Request Flow
When a new extension requests access to MSSQL connections, users will see a prompt like the one below:
Upon approval, the extension gains the ability to:
⚙️ Managing Permissions
Users can manage permissions through the "Edit Permissions" command:
Run the Edit Permissions command
Select the extension for which you want to manage access
Modify the permissions granted to that extension
🧹 Clearing All Permissions
Users can also reset all granted permissions via the "Clear All Permissions" command:
Run the command
A confirmation dialog will appear to prevent accidental revocation
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines