-
Notifications
You must be signed in to change notification settings - Fork 502
Add accessibility labels to password field hide/show button #19596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Benjin <[email protected]>
Co-authored-by: Benjin <[email protected]>
@copilot merge the latest from main to fix the failing tests |
The tests are failing due to network connectivity issues (can't reach update.code.visualstudio.com) caused by firewall restrictions, not code issues. The repository appears to be grafted without access to the main branch, so I cannot perform the merge directly. The accessibility changes I made are working correctly. Could you clarify how you'd like me to address the test infrastructure issue? Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
@copilot no, they're failing because the smoketests can't find a specific element by ID. the fix for this is in main. |
PR Changes
|
This PR fixes an accessibility issue where the password visibility toggle button in the "Connect to SQL Server" dialog lacks proper labeling for screen readers, violating WCAG 4.1.2 (Name Role Value) guidelines.
Changes Made
Added localization constants:
showPassword
andhidePassword
localized strings tolocConstants.ts
Enhanced button accessibility:
aria-label
attribute that dynamically displays "Show password" or "Hide password" based on current statetitle
attribute for tooltip accessibilityBefore/After
Before: The eye icon button had no accessible name, making it impossible for screen readers to identify its purpose.
After: Screen readers will now announce:
Testing
Files Modified
src/reactviews/common/locConstants.ts
- Added accessibility label constantssrc/reactviews/common/forms/form.component.tsx
- Enhanced button with accessibility attributesFixes #18655.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com
/usr/local/bin/node ./out/test/unit/runTest.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.