-
Notifications
You must be signed in to change notification settings - Fork 502
Improve Schema Compare Differences List #19641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lewis-sanchez
merged 13 commits into
main
from
lewissanchez/fix-accessibility-diff-list-issue
Jun 25, 2025
Merged
Improve Schema Compare Differences List #19641
lewis-sanchez
merged 13 commits into
main
from
lewissanchez/fix-accessibility-diff-list-issue
Jun 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quick suggestions based on the gif.
|
PR Changes
|
aasimkhan30
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
I'm aware of the new rule surrounding a single PR fixing a single issue, but by replacing the table components with the datagrid component, I was able to fix these issues with a single change.
This PR fixes #19365
This PR fixes #19178
This PR fixes #19182
This PR replaces the Table Fluent UI component that was previously used to list all schema comparison differences with the DataGrid Fluent UI component. The DataGrid component features long text truncation, features a better layout for consistent checkbox alignment, and built in keyboard accessibility.
Improved keyboard navigation
Checkbox alignment:
Before:

Previously when the schema comparison differences list was small, a scrollbar wouldn't appear which would cause table body rows to shift to the right and get out of alignment.
But if the differences list contained a scroll bar then rows would appear correctly aligned:

After:

With the changes in this PR that alignment issue with checkboxes is fixed as seen here with a small differences list:
And here with a differences list that contains a scroll bar:

Long source/target names no longer overlap with checkboxes.
Before:

Long text overlaps with checkboxes in the schema compare differences.
After:

Long names are truncated, so that they don't overlap with the checkboxes like they did previously:
Compacted row height:
Fixed spinner alignment issue:
In the gif, the spinner appears slightly to the left of the checkboxes, but that is now fixed as seen here:

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.
Code Changes Checklist
npm run test
)Reviewers: Please read our reviewer guidelines