change go to symbol in workspace shortcut to Include ALT

[konavivekramakrishna]

Fixes : #232381

Included Alt (option) for Go to Symbol in Workspace

[konavivekramakrishna]

@TylerLeonhardt could you please check this?

Also, I tried to see if there are any existing tests that might be breaking, but I found that there are none.
Would you like me to update the documentation?

[jrieken]

I like the intention of this change but this PR would change it for all platforms, e.g also desktop is not wanted.

The way to tackle this is to have another keybinding that is guarded with a isWebContext context key

[TylerLeonhardt]

Additionally, the proposal in this PR would have CMD+alt+T not CTRL+alt+T on macOS. You will need to use WinCtrl instead of CtrlCmd for macOS

[konavivekramakrishna]

@jrieken @TylerLeonhardt

Is this implementation correct?
I’m unsure how to launch the source version of VS Code in the web environment.
Currently, I am using ./scripts/code.bat to launch VS Code, but I’m not sure how to do this for the web (connect).

Am I missing any edge cases? If so, could you please point out where I’m going wrong?

[jrieken]

but I’m not sure how to do this for the web (connect).

You can use these script scripts: ./scripts/code-server or ./scripts/code-web

[konavivekramakrishna]

Thanks for the command

ps : not working as expected, will update!

[konavivekramakrishna]

@jrieken
I have tried a few approaches, including adding a fallback for "Go to Symbol in Workspace" for the web, but I’m unsure why it is not working in the web environment.

super({
    id: Constants.SearchCommandIds.ShowAllSymbolsActionId,
    title: {
        ...nls.localize2('showTriggerActions', "Go to Symbol in Workspace..."),
        mnemonicTitle: nls.localize({ key: 'miGotoSymbolInWorkspace', comment: ['&& denotes a mnemonic'] }, "Go to Symbol in &&Workspace..."),
    },
    f1: true,
    keybinding: [
        {
            weight: KeybindingWeight.WorkbenchContrib,
            primary: KeyMod.CtrlCmd | KeyCode.KeyT
        },
        {
            weight: KeybindingWeight.WorkbenchContrib,
            when: ContextKeyExpr.and(IsWebContext),
            primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KeyE,
        }
    ],
    menu: {
        id: MenuId.MenubarGoMenu,
        group: '3_global_nav',
        order: 2
    }
});

Ideally, the keybinding Ctrl + Alt + E should toggle the "Go to Symbol in Workspace" feature on the web, but it does not seem to work. (Referred PR : #184585)

it also occurs in the native Windows app when assigning the keybinding Ctrl + Alt + E or Ctrl + Alt + E`.

Can you please help identify the issue or point out what might be going wrong?

[jrieken]

Try running npm compile-web. This compiles extensions like TS for the web and I believe it only appears as not working while the true cause might be no extension support