Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose shell type to extensions #238071

Merged
merged 14 commits into from
Jan 17, 2025
Merged

Expose shell type to extensions #238071

merged 14 commits into from
Jan 17, 2025

Conversation

anthonykim1
Copy link
Contributor

Resolves: #230165

Everything from #237624 but based on upstream/main not my fork.

PowerShell,
Python,
Julia,
NuShell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add Node as a shell type after updating the branch #238127

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I added them here
Now

@anthonykim1 anthonykim1 marked this pull request as ready for review January 17, 2025 19:44
@anthonykim1 anthonykim1 requested a review from Tyriar January 17, 2025 19:44
@anthonykim1 anthonykim1 added this to the January 2025 milestone Jan 17, 2025
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@anthonykim1 anthonykim1 merged commit 57e4810 into main Jan 17, 2025
8 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/shellTypeAPI branch January 17, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API to access the shell type for a given terminal
2 participants