Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable wco on macOS #239666

Merged
merged 5 commits into from
Feb 7, 2025
Merged

feat: enable wco on macOS #239666

merged 5 commits into from
Feb 7, 2025

Conversation

deepak1556
Copy link
Collaborator

Starting PR to see if we can unify the use of navigator.windowControlsOverlay across platform.

The traffic lights are controlled similar to titlebarStyle: 'hidden' mode, instead of calling setTitleBarOverlay we adjust the height via setWindowButtonPosition. Color and symbol color does not apply to traffic lights.

@deepak1556 deepak1556 requested review from bpasero and sbatten February 5, 2025 06:28
@deepak1556 deepak1556 self-assigned this Feb 5, 2025
@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 5, 2025
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am searching through our code to understand where we depend on window.*overlay or WCO and I think in each case we need to revisit what this means for macOS:

@bpasero bpasero requested review from benibenj and removed request for sbatten and benibenj February 6, 2025 08:17
@bpasero bpasero enabled auto-merge (squash) February 7, 2025 09:22
@bpasero bpasero merged commit a9dd4d3 into main Feb 7, 2025
7 checks passed
@bpasero bpasero deleted the robo/enable_wco_macOS branch February 7, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants