Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Changes for preparation to integrate with azure-devopos-extension-sdk #161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/VSS.SDK.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

124 changes: 117 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vss-web-extension-sdk",
"version": "5.140.0",
"version": "5.140.1",
"description": "Visual Studio Team Services web extension JavaScript library and types.",
"repository": {
"type": "git",
Expand Down Expand Up @@ -31,10 +31,10 @@
"@types/knockout": "^3.4.49",
"@types/mousetrap": "~1.5.34",
"@types/q": "0.0.32",
"@types/react": "^15.6.12",
"@types/react": "^16.8.2",
"@types/requirejs": ">=2.1.28"
},
"devDependencies": {
"typescript": "~2.5.3"
"typescript": "^3.9.6"
}
}
5 changes: 4 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
"dom"
],
"skipLibCheck": true,
"types": []
"types": [],
"strict": true,
"noImplicitAny": true,
"noImplicitThis": true
},
"include": [
"typings/**/*.ts"
Expand Down
2 changes: 1 addition & 1 deletion typings/VSS.SDK.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ declare module XDM {
* @param instanceId unique id of the registered object
* @param contextData Optional context data to pass to a registered object's factory method
*/
getInstance<T>(instanceId: string, contextData?: Object): T;
getInstance<T>(instanceId: string, contextData?: Object): T | undefined ;
}
/**
* The registry of global XDM handlers
Expand Down
17 changes: 11 additions & 6 deletions typings/vss.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ interface IXDMChannelManager {
*
* @param channel The channel to remove from the channel manager
*/
removeChannel(channel: IXDMChannel);
removeChannel(channel: IXDMChannel) : void;
}

/**
Expand Down Expand Up @@ -200,7 +200,7 @@ interface IXDMObjectRegistry {
* @param instanceId unique id of the registered object
* @param contextData Optional context data to pass to the contructor of an object factory method
*/
getInstance<T>(instanceId: string, contextData?: Object): T;
getInstance<T>(instanceId: string, contextData?: Object): T | undefined ;
}

/**
Expand Down Expand Up @@ -246,6 +246,11 @@ interface IExtensionInitializationOptions {
* If true, send back the theme data as part of the initial handshake
*/
applyTheme?: boolean;

/**
* If set will use the channel specified for all commmunication
*/
parentChannel?: IXDMChannel;
}

/**
Expand Down Expand Up @@ -470,19 +475,19 @@ interface IExternalDialog {
/**
* Close the dialog
*/
close();
close(): void;

/**
* Update the title of the dialog
*
* @param title New dialog title
*/
setTitle(title: string);
setTitle(title: string): void;

/**
* Update the enablement of the OK button
*/
updateOkButton(enabled: boolean);
updateOkButton(enabled: boolean): void;
}

/**
Expand Down Expand Up @@ -804,7 +809,7 @@ interface IContributedMenuSource {
*
* @param actionContext Menu-specific context information
*/
execute?(actionContext: any);
execute?(actionContext: any): void;
}

/**
Expand Down