Always treat warnings as errors (#3210)

microsoft · Aug 19, 2024 · 1e662ff · 1e662ff
1 parent f19edde
commit 1e662ff
Show file tree

Hide file tree

Showing 24 changed files with 5 additions and 67 deletions.
diff --git a/.cargo/config.toml b/.cargo/config.toml
@@ -1,5 +1,7 @@
 [build]
 rustflags = [
+    "-D", "warnings",
+
     # "--cfg", "windows_debugger_visualizer",
     # "--cfg", "windows_raw_dylib",
     # "--cfg", "windows_slim_errors",

diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     runs-on: windows-2022

diff --git a/.github/workflows/cross.yml b/.github/workflows/cross.yml
@@ -9,7 +9,6 @@ on:
       - master
 
 env:
-  RUSTFLAGS: -Dwarnings
   LLVM-MINGW-TOOLCHAIN-NAME: llvm-mingw-20220906-ucrt-ubuntu-18.04-x86_64
 
 jobs:

diff --git a/.github/workflows/debugger_visualizer.yml b/.github/workflows/debugger_visualizer.yml
@@ -9,7 +9,7 @@ on:
       - master
 
 env:
-  RUSTFLAGS: -Dwarnings --cfg windows_debugger_visualizer
+  RUSTFLAGS: --cfg windows_debugger_visualizer
 
 jobs:
   check:

diff --git a/.github/workflows/doc.yml b/.github/workflows/doc.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   windows:
     name: windows

diff --git a/.github/workflows/fmt.yml b/.github/workflows/fmt.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/gen.yml b/.github/workflows/gen.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     name: tool_${{ matrix.tool }}

diff --git a/.github/workflows/lib.yml b/.github/workflows/lib.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     runs-on: windows-2022

diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/msrv-windows-bindgen.yml b/.github/workflows/msrv-windows-bindgen.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/msrv-windows-core.yml b/.github/workflows/msrv-windows-core.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/msrv-windows-metadata.yml b/.github/workflows/msrv-windows-metadata.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/msrv-windows-registry.yml b/.github/workflows/msrv-windows-registry.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/msrv-windows-result.yml b/.github/workflows/msrv-windows-result.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/msrv-windows-strings.yml b/.github/workflows/msrv-windows-strings.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/msrv-windows-sys.yml b/.github/workflows/msrv-windows-sys.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/msrv-windows-version.yml b/.github/workflows/msrv-windows-version.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/msrv-windows.yml b/.github/workflows/msrv-windows.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/no-default-features.yml b/.github/workflows/no-default-features.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     runs-on: windows-2022

diff --git a/.github/workflows/no_std.yml b/.github/workflows/no_std.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     strategy:

diff --git a/.github/workflows/raw_dylib.yml b/.github/workflows/raw_dylib.yml
@@ -9,7 +9,7 @@ on:
       - master
 
 env:
-  RUSTFLAGS: -Dwarnings --cfg windows_raw_dylib
+  RUSTFLAGS: --cfg windows_raw_dylib
 
 jobs:
   check:

diff --git a/.github/workflows/slim_errors.yml b/.github/workflows/slim_errors.yml
@@ -9,7 +9,7 @@ on:
       - master
 
 env:
-  RUSTFLAGS: -Dwarnings --cfg windows_slim_errors
+  RUSTFLAGS: --cfg windows_slim_errors
 
 jobs:
   check:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -8,9 +8,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     runs-on: windows-2022

diff --git a/crates/tools/yml/src/main.rs b/crates/tools/yml/src/main.rs
@@ -17,9 +17,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     runs-on: windows-2022
@@ -114,9 +111,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     runs-on: windows-2022
@@ -166,9 +160,6 @@ on:
     branches:
       - master
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   check:
     runs-on: windows-2022