-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable Event implementation #3198
Merged
Merged
Commits on Aug 12, 2024
-
use RwLock for interior mutability
No deadlock reasoning: - RwLock can block when reader and writer threads are contesting access - When swap lock is acquired, we either have: - an exclusive write access from one of add, remove, or clear - a shared read access from call and one of add, remove, or clear - Otherwise, - when a change lock is acquired, we have a single read access from one of add, remove, or clear - when no lock is acquired, there is no access - Therefore delegates shouldn't deadlock
Configuration menu - View commit details
-
Copy full SHA for 2d7829a - Browse repository at this point
Copy the full SHA 2d7829aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09a4de9 - Browse repository at this point
Copy the full SHA 09a4de9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0337f17 - Browse repository at this point
Copy the full SHA 0337f17View commit details
Commits on Aug 13, 2024
-
Assuming we have an exclusive access to the array
Configuration menu - View commit details
-
Copy full SHA for 33d8896 - Browse repository at this point
Copy the full SHA 33d8896View commit details -
Assuming we have an exclusive access to the array
Configuration menu - View commit details
-
Copy full SHA for db90add - Browse repository at this point
Copy the full SHA db90addView commit details -
Assuming we have exclusive access to the array
Configuration menu - View commit details
-
Copy full SHA for 48024c2 - Browse repository at this point
Copy the full SHA 48024c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49509e8 - Browse repository at this point
Copy the full SHA 49509e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 253a005 - Browse repository at this point
Copy the full SHA 253a005View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0df0b2 - Browse repository at this point
Copy the full SHA b0df0b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdaeb15 - Browse repository at this point
Copy the full SHA fdaeb15View commit details
Commits on Aug 15, 2024
-
Replace
Array<T>
with Rust typesThe `Option` that wraps `Arc<[Delegate<T>]>` will let us assign `None` instead of creating `Arc::new([])` with no space penalty.
Configuration menu - View commit details
-
Copy full SHA for 9e4a471 - Browse repository at this point
Copy the full SHA 9e4a471View commit details
Commits on Aug 16, 2024
-
construct Arc directly from iterator
Now we only need to allocate once for Arc
Configuration menu - View commit details
-
Copy full SHA for 9449391 - Browse repository at this point
Copy the full SHA 9449391View commit details -
Configuration menu - View commit details
-
Copy full SHA for d987a51 - Browse repository at this point
Copy the full SHA d987a51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 520b595 - Browse repository at this point
Copy the full SHA 520b595View commit details -
Configuration menu - View commit details
-
Copy full SHA for dff4499 - Browse repository at this point
Copy the full SHA dff4499View commit details -
Configuration menu - View commit details
-
Copy full SHA for 208e52f - Browse repository at this point
Copy the full SHA 208e52fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf72954 - Browse repository at this point
Copy the full SHA bf72954View commit details -
Take the guard as late as possible
Co-authored-by: Kenny Kerr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b0bc9b1 - Browse repository at this point
Copy the full SHA b0bc9b1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.