Addressing comments

microsoft · Oct 2, 2024 · d393bf1 · d393bf1
1 parent 7b48281
commit d393bf1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/AppInstallerCLICore/Workflows/SmartScreenFlow.cpp b/src/AppInstallerCLICore/Workflows/SmartScreenFlow.cpp
@@ -81,10 +81,10 @@ namespace AppInstaller::CLI::Workflow
 
         if (IsSmartScreenRequired(zone) && IsBlockedBySmartScreen(context, uri))
         {
-            return APPINSTALLER_CLI_ERROR_SOURCE_NOT_SECURE;
+            return APPINSTALLER_CLI_ERROR_BLOCKED_BY_REPUTATION_SERVICE;
         }
 
-        return NO_ERROR;
+        return S_OK;
     }
 
     void EvaluateUri(Execution::Context& context)
@@ -97,7 +97,7 @@ namespace AppInstaller::CLI::Workflow
             {
                 context.Reporter.Info() << "Validating Uri: " << argPath;
                 auto uriValidation = EvaluateUri(context, argPath);
-                if (uriValidation != NO_ERROR)
+                if (FAILED(uriValidation))
                 {
                     AICLI_LOG(Config, Error, << "URI validation blocked this uri: " << argPath);
                     AICLI_TERMINATE_CONTEXT(uriValidation);

diff --git a/src/AppInstallerSharedLib/Public/AppInstallerErrors.h b/src/AppInstallerSharedLib/Public/AppInstallerErrors.h
@@ -149,6 +149,7 @@
 #define APPINSTALLER_CLI_ERROR_SFSCLIENT_API_FAILED                 ((HRESULT)0x8A150081)
 #define APPINSTALLER_CLI_ERROR_NO_APPLICABLE_SFSCLIENT_PACKAGE      ((HRESULT)0x8A150082)
 #define APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED                 ((HRESULT)0x8A150083)
+#define APPINSTALLER_CLI_ERROR_BLOCKED_BY_REPUTATION_SERVICE        ((HRESULT)0x8A150084)
 
 // Install errors.
 #define APPINSTALLER_CLI_ERROR_INSTALL_PACKAGE_IN_USE                   ((HRESULT)0x8A150101)