Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read registry value data on demand #3642

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Sep 19, 2023

Change

When enumerating registry keys, move the code that reads the registry value data to be on request rather than during the iterator advancement. This enables code that doesn't need the data to simply skip it, and code that does to better handle the error if desired.

Validation

Regression only.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner September 19, 2023 18:25
@JohnMcPMS JohnMcPMS linked an issue Sep 19, 2023 that may be closed by this pull request
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit 5a6134a into microsoft:master Sep 19, 2023
@JohnMcPMS JohnMcPMS deleted the regvalue-dataondemand branch September 19, 2023 22:31
@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to open the predefined source;
2 participants