Improve the version header detection and logging #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranm-msft
approved these changes
Sep 27, 2023
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Sep 27, 2023
JohnMcPMS
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
I have seen the header detection fall back exactly one time unexpectedly. It did not fail (no throw in the try/catch block), and I was running Fiddler and saw the header present.
Because it happening to me once could me happening in the wild thousands or millions of times, this change folds the case of the headers to ensure that they are in fact lower case and adds logging to dump the headers to make it easier to diagnose in case it ever happens again.
Validation
Still works, but since I have no idea why it failed the one time, I can't really say it has been resolved. Hopefully that means it was a special case.
Microsoft Reviewers: Open in CodeFlow