Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 3657 to 1.6 #3682

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Sep 27, 2023

Pull #3657 into 1.6

Microsoft Reviewers: Open in CodeFlow

This change refactors the index package updating to enable an optimization; using an HTTP header to determine the available version rather than reading the package contents remotely.  If the header is present, containing a valid package version string, it will be used as the available version.  If not, the existing package content examination will be used.

The refactoring was required to do all package inspection steps after downloading the package, rather than before.  This enables the single version value to be sufficient until we decide to update, and then in the very unlikely event of the package not meeting criteria we will delete it after having downloaded it.
@JohnMcPMS JohnMcPMS requested a review from a team as a code owner September 27, 2023 02:04
@JohnMcPMS
Copy link
Member Author

Apparently github wants to attach the checks run from the other PR onto this one. Ignore the failed builds, that is from me closing the PR target the main branch by mistake.

@JohnMcPMS JohnMcPMS merged commit f600c3b into microsoft:release-v1.6 Sep 27, 2023
7 of 11 checks passed
@JohnMcPMS JohnMcPMS deleted the cp-3657 branch September 27, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants