Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing manifest fields #3757

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Add missing manifest fields #3757

merged 4 commits into from
Oct 24, 2023

Conversation

hackean-msft
Copy link
Contributor

@hackean-msft hackean-msft commented Oct 11, 2023 •
edited
Loading

  • I have signed the Contributor License Agreement.
  • This pull request is related to an issue.
  • [ ]
    Adding fields that are present in manifest schema but missing in the manifest model.

@hackean-msft hackean-msft requested a review from a team as a code owner October 11, 2023 20:03
@yao-msft
Copy link
Contributor

Please update the tests at https://github.com/microsoft/winget-cli/blob/master/src/WinGetUtilInterop.UnitTests/ManifestUnitTest/V1ManifestReadTest.cs so we know the new fields are working.

Also since we are updating, please update to the latest 1,6 schema manifests.

yao-msft
yao-msft approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hackean-msft hackean-msft merged commit 0d824f4 into master Oct 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackean-msft @yao-msft